Skip to content

Import Literal from typing_extensions if from typing fails#114

Merged
rromb merged 1 commit intoCompVis:masterfrom
olaviinha:master
Oct 7, 2021
Merged

Import Literal from typing_extensions if from typing fails#114
rromb merged 1 commit intoCompVis:masterfrom
olaviinha:master

Conversation

@olaviinha
Copy link
Contributor

@olaviinha olaviinha commented Oct 7, 2021

Fixes the issue of Google Colab failing at importing Literal from typing instead of typing_extensions. Please assess.


You can observe the problem in your own demo notebook: https://colab.research.google.com/github/CompVis/taming-transformers/blob/master/scripts/taming-transformers.ipynb

image

Python 3.7.12 suddenly started failing at importing Literal from typing. Work when imported from typing_extensions instead.
@rromb rromb merged commit 3121649 into CompVis:master Oct 7, 2021
@rromb
Copy link
Collaborator

rromb commented Oct 7, 2021

Thanks!

@rromb rromb mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants